[ARM:Bugfix] Enable MNNRankOneUpdate fallback on Apple Silicon#4579
Open
lanling-47 wants to merge 1 commit into
Open
[ARM:Bugfix] Enable MNNRankOneUpdate fallback on Apple Silicon#4579lanling-47 wants to merge 1 commit into
lanling-47 wants to merge 1 commit into
Conversation
The MNNRankOneUpdateDefault C++ fallback was guarded by #ifndef __aarch64__, which excludes Apple Silicon (which also defines __aarch64__). However, the NEON assembly path for MNNRankOneUpdate is not wired up for this op on Apple platforms, causing a missing implementation at link/runtime. Fix by also compiling the fallback when __APPLE__ is defined. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
MNNRankOneUpdateDefaultC++ fallback was guarded by#ifndef __aarch64__, which excludes Apple Silicon (which also defines__aarch64__). However, the NEON assembly path forMNNRankOneUpdateis not wired up for this op on Apple platforms, causing a missing implementation at link/runtime.Fix by changing the guard to
#if !defined(__aarch64__) || defined(__APPLE__), so the fallback is compiled on Apple Silicon as well.Tested on: Apple M4 (ARM64, Apple Silicon)
Module
Type
Checklist
[Module:Type] Description